Added support for automaticallyWaitsToMinimizeStalling property on iOS #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnfb
suggested changes
Aug 29, 2019
|
All change requests have been resolved! |
fix crash iOS9
ashnfb
approved these changes
Sep 3, 2019
CHaNGeTe
approved these changes
Sep 21, 2019
|
To be released |
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
Added support for automaticallyWaitsToMinimizeStalling property on iOS (rebased from commit 59be8b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This pull request adds the
automaticallyWaitsToMinimizeStallingproperty which is available on iOS only starting from iOS 10. The property is set totrueby default.From the official Apple documentation (https://developer.apple.com/documentation/avfoundation/avplayer/1643482-automaticallywaitstominimizestal?language=objc)
A Boolean value that indicates whether the player should automatically delay playback in order to minimize stalling.
Update the documentation
The property has been added to the documentation
Update the changelog
The changelog is updated mentioning the current pull request
Provide an example of how to test the change
The changes can be tested with any video by implementing the
automaticallyWaitsToMinimizeStallingprop onVideoand setting it tofalse.